Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support client_secret_post #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

strehle
Copy link
Member

@strehle strehle commented Sep 8, 2023

client_secret_post means client_id and client_secret in body of request not in authorization header

client_secret_post means client_id and client_secret in body of request not in authorization header
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186000366

The labels on this github issue will be updated when the story is started.

@gitguardian
Copy link

gitguardian bot commented Sep 8, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
8047040 Base64 Basic Authentication 6b86b95 spec/token_issuer_spec.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@strehle strehle requested review from peterhaochen47 and a team September 8, 2023 12:54
@strehle
Copy link
Member Author

strehle commented Sep 8, 2023

created this after review of #90

@strehle
Copy link
Member Author

strehle commented Nov 18, 2024

Can somone please review this

Copy link
Member

@duanemay duanemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Merge | Prioritized
Development

Successfully merging this pull request may close these issues.

3 participants